diff options
| author | Alan Wu <XrXr@users.noreply.github.com> | 2023-01-16 15:30:18 -0500 |
|---|---|---|
| committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2024-05-08 20:12:13 +0900 |
| commit | a10a0d0c77826b97ec246274adcc80952049688b (patch) | |
| tree | d8c397b17b269df883b9aee7acc469ad6fa34537 | |
| parent | 8029ee41768cdc6b86cad90390f281185ab995e2 (diff) | |
CI: Pass -O2 for annocheckruby_3_2
Because `optflags` is pasted into the invocation line after `CC`, we were
building with -O1 unintentionally. You can see this in the configuration
summary: https://github.com/ruby/ruby/actions/runs/3933391169/jobs/6727044423#step:9:753
The check actually fails with -O2. To make it pass, upstream suggest
that we use the annocheck GCC plugin. Since it requires building from
source as the debian package for it isn't ready yet, punt on it for now
and use `--skip-gaps`.
Co-authored-by: Jun Aruga <jaruga@redhat.com>
| -rw-r--r-- | .github/workflows/compilers.yml | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/.github/workflows/compilers.yml b/.github/workflows/compilers.yml index 93d2d81550..731bda1cda 100644 --- a/.github/workflows/compilers.yml +++ b/.github/workflows/compilers.yml @@ -91,12 +91,13 @@ jobs: container: gcc-11 env: # Minimal flags to pass the check. - default_cc: 'gcc-11 -O2 -fcf-protection -Wa,--generate-missing-build-notes=yes' + default_cc: 'gcc-11 -fcf-protection -Wa,--generate-missing-build-notes=yes' + optflags: '-O2' LDFLAGS: '-Wl,-z,now' # FIXME: Drop skipping options # https://bugs.ruby-lang.org/issues/18061 # https://sourceware.org/annobin/annobin.html/Test-pie.html - TEST_ANNOCHECK_OPTS: "--skip-pie" + TEST_ANNOCHECK_OPTS: "--skip-pie --skip-gaps" check: true - { name: clang-16, env: { default_cc: clang-16 } } - { name: clang-15, env: { default_cc: clang-15 } } |